Dynamic release coefficient k #201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done a small change in the reservoirs.py module.
The release coefficient
self.var.kis now calculated in thedynamic_inloop()method based on the current reservoir storage. Before, this coefficient was fixed and computed in theinitial()method based only on the flood storage limit.With this change, we try to improve the reservoir releases in big reservoirs whose$k$ parameter was 0 in the original CaMa-Flood routine. In those reservoirs, the release was always fixed to a the non-damaging outflow ($Q_f$ ). In the new implementation, when the reservoirs fills up, the release might be larger than $Q_f$ .